fix #2: support stdin #3
Conversation
|
Some of the changes to |
|
Awesome! I'll review this soon, thanks for working on it.
That lock file is really turning out to be more trouble than it's worth a lot of times. Might just get rid of it for this particular project. |
|
I usually don't have lock files for libraries and keep them in "top level" apps only (e.g. something that is deployed). |
Yeah that's what I'm finding also. We're gonna get rid of it here. I'll leave that for after this merges. |
cli.js
Outdated
| @@ -33,5 +28,11 @@ if (flags.columns.length > 0) { | |||
| options.columns = flags.align.map(align => ({ align })) | |||
| } | |||
|
|
|||
| // write results to stdout | |||
| console.log(convert(input, options)) | |||
| stdin.then(function( stdin ){ | |||
There was a problem hiding this comment.
These are just style nitpicks if you can get to them. Could you make this an arrow function? I also don't necessarily like shadowing variables if we can help it so let's rename the param to input since that's freed up now.
stdin.then(input => {There was a problem hiding this comment.
I don't mind style nitpicking. I'd do the same.
|
(I expect a squash before merging) |
No description provided.