Apply the 'osgi' plugin, so the jar includes a bundle manifest. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes hamcrest#11. The plugin automatically determines Import-Package and Export-Package based on analysis of the classes, and also adds Tool, Bundle-Name, Bundle-Version, Bundle-SymbolicName and others.
|
I don't know enough about OSGi to judge. Any other OSGi users want to review this? Or is there a way to write an automated test for the expected OSGi behaviour that this change will produce? |
|
As a basic check, Apache Karaf offers a console. With that running, It would be possible to test this by writing something with, say, Felix or Equinox. |
|
Can you mark the xml import packages as optional if they are only used for XML matching capabilities? That way you won't have to poke holes in your bootdelegation list to spark up hamcrest if one is not using XML |
The only packages imported currently are XML packages only used for optional functionality. Make the imports optional so the bundle can be used without them being available.
Specifically list the packages that are optional. This won't affect the current Import-Package, but it will mean that new additions don't surprise by appearing as optional in future.
|
Good catch. I've updated the PR to make those imports optional: |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11. The plugin automatically determines Import-Package and
Export-Package based on analysis of the classes, and also adds
Tool, Bundle-Name, Bundle-Version, Bundle-SymbolicName and
others.
The manifest after this change looks like:
which looks right.