Skip to content

Commit

Permalink
fix(DX): make warnings go to stderr
Browse files Browse the repository at this point in the history
  • Loading branch information
ankush committed Aug 10, 2022
1 parent dea3278 commit b6b9481
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions bench/utils/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def is_valid_frappe_branch(frappe_path: str, frappe_branch: str):
raise InvalidRemoteException(f"Invalid frappe path: {frappe_path}") from e


def log(message, level=0, no_log=False):
def log(message, level=0, no_log=False, stderr=False):
import bench
import bench.cli

Expand All @@ -96,13 +96,13 @@ def log(message, level=0, no_log=False):
bench.LOG_BUFFER.append({"prefix": prefix, "message": message, "color": color})

if no_log:
click.secho(message, fg=color)
click.secho(message, fg=color, err=stderr)
else:
loggers = {2: logger.error, 3: logger.warning}
level_logger = loggers.get(level, logger.info)

level_logger(message)
click.secho(f"{prefix}: {message}", fg=color)
click.secho(f"{prefix}: {message}", fg=color, err=stderr)


def check_latest_version():
Expand All @@ -125,7 +125,7 @@ def check_latest_version():
local_version = Version(VERSION)

if pypi_version > local_version:
log(f"A newer version of bench is available: {local_version}{pypi_version}")
log(f"A newer version of bench is available: {local_version}{pypi_version}", stderr=True)


def pause_exec(seconds=10):
Expand Down

0 comments on commit b6b9481

Please sign in to comment.