Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text with example. #4

Merged
merged 6 commits into from Aug 27, 2019
Merged

Update text with example. #4

merged 6 commits into from Aug 27, 2019

Conversation

hameerabbasi
Copy link
Owner

@hameerabbasi hameerabbasi commented Aug 24, 2019

@hameerabbasi hameerabbasi merged this pull request into uarray Aug 27, 2019
@hameerabbasi hameerabbasi deleted the uarray-me branch August 27, 2019 14:49
@peterbell10
Copy link
Collaborator

A small thing missing from this backend example is that it will raise KeyError in cases where it should be returning NotImplemented. The fix is here peterbell10@7cd6258.

I would have opened a pull-request but I can’t seem to do it against your fork. Possibly a permission issue?

@peterbell10
Copy link
Collaborator

That would be important in calling the default implementations of ones and zeros for example.

@hameerabbasi
Copy link
Owner Author

A small thing missing from this backend example is that it will raise KeyError in cases where it should be returning NotImplemented. The fix is here peterbell10@7cd6258.

I would have opened a pull-request but I can’t seem to do it against your fork. Possibly a permission issue?

I can't do it either, weird. Anyway, I merged the changes into my amended commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants