New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of double colon when referencing Rails #930

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
4 participants
@emaxi

emaxi commented May 21, 2017

This is related to #868

I got next error when using :sass filter:
NoMethodError - undefined method `application' for Haml::Rails:Module.

Just adding double colon to Rails.application solved the error to me.

@k0kubun

This comment has been minimized.

Show comment
Hide comment
@k0kubun

k0kubun May 24, 2017

Member

Ah, Haml::Rails module is created by haml-rails and it would be broken.

Thanks for the patch!

Member

k0kubun commented May 24, 2017

Ah, Haml::Rails module is created by haml-rails and it would be broken.

Thanks for the patch!

@k0kubun k0kubun merged commit 47d88fc into haml:master May 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aselder

This comment has been minimized.

Show comment
Hide comment
@aselder

aselder Jul 26, 2017

@k0kubun Can we get a 5.0.2 release so this fix can go out?

aselder commented Jul 26, 2017

@k0kubun Can we get a 5.0.2 release so this fix can go out?

@k0kubun

This comment has been minimized.

Show comment
Hide comment
@k0kubun

k0kubun Jul 26, 2017

Member

I'm not a release manager. ping @amatsuda

Member

k0kubun commented Jul 26, 2017

I'm not a release manager. ping @amatsuda

@amatsuda

This comment has been minimized.

Show comment
Hide comment
@amatsuda

amatsuda Jul 28, 2017

Member

OK. I'll publish 5.0.2 within a day or so.

Member

amatsuda commented Jul 28, 2017

OK. I'll publish 5.0.2 within a day or so.

@amatsuda

This comment has been minimized.

Show comment
Hide comment
@amatsuda

amatsuda Aug 1, 2017

Member

@aselder @k0kubun Sorry for the delay. Just released 5.0.2 gem with this change. Thanks!

Member

amatsuda commented Aug 1, 2017

@aselder @k0kubun Sorry for the delay. Just released 5.0.2 gem with this change. Thanks!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 10, 2017

taca
Update ruby-haml to 5.0.3.
## 5.0.3

Released on September 7, 2017
([diff](haml/haml@v5.0.2...v5.0.3)).

* Use `String#dump` instead of `String#inspect` to generate string
  literal. (Takashi Kokubun)
* Fix Erubi superclass mismatch
  error. [#952](haml/haml#952) (thanks [Robin
  Daugherty](https://github.com/RobinDaugherty))

## 5.0.2

Released on August 1, 2017
([diff](haml/haml@v5.0.1...v5.0.2)).

* Let `haml -c` fail if generated Ruby code is syntax
  error. [#880](haml/haml#880) (Takashi Kokubun)
* Fix `NoMethodError` bug caused with Sprockets 3 and :sass
  filter. [#930](haml/haml#930) (thanks [Gonzalez
  Maximiliano](https://github.com/emaxi))
* Fix `list_of` helper with multi-line
  content. [#933](haml/haml#933) (thanks [Benoit
  Larroque](https://github.com/zetaben))
* Optimize rendering performance by changing timing to fix
  textareas. [#941](haml/haml#941) (Takashi Kokubun)
* Fix `TypeError` with empty :ruby
  filter. [#942](haml/haml#942) (Takashi Kokubun)
* Fix inconsistent attribute sort order. (Takashi Kokubun)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment