Fix list_of helper with multi-line content #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 10, 2017
## 5.0.3 Released on September 7, 2017 ([diff](haml/haml@v5.0.2...v5.0.3)). * Use `String#dump` instead of `String#inspect` to generate string literal. (Takashi Kokubun) * Fix Erubi superclass mismatch error. [#952](haml/haml#952) (thanks [Robin Daugherty](https://github.com/RobinDaugherty)) ## 5.0.2 Released on August 1, 2017 ([diff](haml/haml@v5.0.1...v5.0.2)). * Let `haml -c` fail if generated Ruby code is syntax error. [#880](haml/haml#880) (Takashi Kokubun) * Fix `NoMethodError` bug caused with Sprockets 3 and :sass filter. [#930](haml/haml#930) (thanks [Gonzalez Maximiliano](https://github.com/emaxi)) * Fix `list_of` helper with multi-line content. [#933](haml/haml#933) (thanks [Benoit Larroque](https://github.com/zetaben)) * Optimize rendering performance by changing timing to fix textareas. [#941](haml/haml#941) (Takashi Kokubun) * Fix `TypeError` with empty :ruby filter. [#942](haml/haml#942) (Takashi Kokubun) * Fix inconsistent attribute sort order. (Takashi Kokubun)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The current
list_ofhelper in haml 5.0.1 seem to have an issue when running in rails (at least in 5.0.0.1) when inserting multi-line content.In my rails app when I do a block
link_toin thelist_of, the content of the list is removed:It seem to be linked to the use of
strip!instead ofstripthe!version will actually return nil if does nothing.I managed to add a test that seem to replicate the issue without rails. It could also probably be fixed using an
result.strip! || resultwhich would not copyresult.Thanks again for HAML and saving me from ERB !