fix #768 issue (Manager.off method) #839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| delete handlers[event]; | ||
| } else { | ||
| handlers[event].splice(inArray(handlers[event], handler), 1); | ||
| if (typeof handlers[event] !== 'undefined') { |
There was a problem hiding this comment.
do we really need to check typeof handlers[event] !== 'undefined' here isn't it enough to just check handlers[event] ?
There was a problem hiding this comment.
your opinion is better. ok. I will change code.
how about following code?
if (!handler) {
delete handlers[event];
} else {
handlers[event] && handlers[event].splice(inArray(handlers[event], handler), 1);
}
|
@sculove 2 small changes i would like to see but looks good thank you. |
When you didn't attach an event and you use a Hammerjs.Manager.off method , you will see script error.
|
@arschmitz Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I resend pr that seperate unrelated changes.
When you didn't attach an event and you use a Hammerjs.Manager.off method , you will see script error.
I think that hammerjs have to handle exception.
I modified Hammerjs.Manager.off method.
also I added test case in test_events.js