Better exception formatting. #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ihodes
commented
Jun 10, 2015
ihodes
commented
| stdout_handler = logging.StreamHandler(sys.stdout) | ||
| stdout_handler.setLevel(logging.INFO) | ||
| formatter = logging.Formatter("%(asctime)s - %(name)s - %(levelname)s - %(message)s") | ||
| formatter = logging.Formatter("""\ |
There was a problem hiding this comment.
No, it escapes the newline.
There was a problem hiding this comment.
weird, did not know this trick.
|
Worth noting that we lose our ability to grep logs by going to a multiline format, but that's not something we've ever done in the past. |
|
Our logs have actually always been in a multi line format! This just adds one more newline (+ some more info) to make it easier to read & grep. On Thu, Jun 11, 2015 at 10:43 AM, Dan Vanderkam notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.