-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TravisCI + Saucelabs to run seltest #720
Conversation
bb4ef54
to
cfe2efd
Compare
4609d0b
to
33b60f2
Compare
Locally and automatically on Travis
Now we blur the input so we don't sometimes capture a screenshot of the cursor blinking. Also generate imgur screenshots on Travis if a test fails. (Add encrypted IMGUR_CLIENT_ID to .travis.yml to support this, too).
Factor out shared config into JSON Don't try to start the SC tunnel if it's already open
33b60f2
to
3ab2f57
Compare
Just a few comments. Thanks for putting in all the work to figure this out! The vertically truncated screenshots issue is unfortunate, but hopefully we can find a workaround. Reviewed 29 of 29 files at r1. .travis.yml, line 11 [r1] (raw file): cycledash/static/scss/style.scss, line 31 [r1] (raw file): DEVELOP.md, line 157 [r1] (raw file): scripts/travis-run-pdiff-tests.sh, line 3 [r1] (raw file): scripts/travis-run-pdiff-tests.sh, line 26 [r1] (raw file): Speaking of which, how do these get set? tests/pdifftests/test.py, line 127 [r1] (raw file): Comments from the review on Reviewable.io |
I agree. Chrome team has been punting on this for years, though. One solution may be to use Firefox. We can also try running Chrome in a headless GUI. Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful. cycledash/static/scss/style.scss, line 31 [r1] (raw file): scripts/travis-run-pdiff-tests.sh, line 26 [r1] (raw file): They're set in the .travis.yml file (now commented), so they'll always be there. Comments from the review on Reviewable.io |
3ab2f57
to
411da38
Compare
LGTM, feel free to merge on green. After this goes in, can you send a quick message to everyone who works on Cycledash summarizing what we need to do (i.e. register for Sauce Labs, set environment variables) to stay up to date? Review status: 24 of 29 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending. Comments from the review on Reviewable.io |
Use TravisCI + Saucelabs to run seltest
This change has two main parts:
./scripts/update-screenshots.sh
starts a test server locally, and then updates the seltest screenshots via a browser on SauceLabs./scripts/travis-run-pdiff-tests.sh
runs the screenshot tests on Travis via a browser on SauceLabsFixes #644.
To do:
SAUCE_USERNAME
andSAUCE_ACCESS_KEY
to be in ENV, but we don't want this in the repo (other than encrypted, like they are in thetravis-test.sh
script).sleep
allowed—Travis seems to do this well).filed #759