Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full page pileup #721

Merged
merged 4 commits into from
Jun 12, 2015
Merged

Full page pileup #721

merged 4 commits into from
Jun 12, 2015

Conversation

danvk
Copy link
Contributor

@danvk danvk commented Jun 12, 2015

Fixes #718

This also fixes the "mousewheel in the pileup track scrolls the variant list" issue. Mousewheeling elsewhere in the variant inspector still does this, but the situation is at least improved!

The full-page pileup view includes a one-row VCFTable. In setting this up, I found a few unused props which I removed.

This uses CSS flexbox to size the tracks in the pileup view. This works so well that I might make it the default in pileup.css.

full page pileup

@jaclynperrone

Review on Reviewable

@ihodes
Copy link
Member

ihodes commented Jun 12, 2015

LGTM, three minor issues:

  1. http://d.pr/i/1edTw
  2. http://d.pr/i/131eh
  3. Some way to get rid of the scrollbar on the main page would be ideal; can't we just not render the main VCFTable if pileup is open?

@danvk
Copy link
Contributor Author

danvk commented Jun 12, 2015

Good suggestion about not rendering the VCFTable when the pileup viewer is open. I reworked ExaminePage.js to show only the pileup or the rest of the examine page, never both. This fixes all three of your minor issues. It also lets me kill the mousewheel hack.

Lemme know what you think.

@ihodes
Copy link
Member

ihodes commented Jun 12, 2015

Awesome, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show pileup view as a full-page when launched
2 participants