Update screenshots to fix broken CI tests on Travis #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: I will merge this trivial one in and continue working on the other ones. |
armish
added a commit
that referenced
this pull request
Aug 27, 2015
Update screenshots to fix broken CI tests on Travis
| capabilities=$(python <<EOF | ||
| import json | ||
| capabilities = json.loads(open('$SELTEST_CAPABILITIES').read()) | ||
| capabilities['tunnel-identifier'] = '$TRAVIS_JOB_NUMBER' |
There was a problem hiding this comment.
./update-screenshots.sh runs locally, so there won't be a TRAVIS_JOB_NUMBER--I think this file should remain the same.
|
Sorry I didn't get to this earlier! The ./update-screenshots.sh script needs to be reverted to the way it was before; cf. my comment on it. I'm not quite sure, but it looks like the issue was sparked this PR was fixed (timestamp issues?), and the screenshots needed to be changed in the end just because of the Chrome version bump to 44? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason unknown to me, our CI tests were failing us due to differing screenshots. See this trivial change in the README file and the corresponding fail report from Travis.
A few pages were off had different renderings of button corners (like run pages). I am not sure why these need an update, but might be due to an update on the Sauce Labs side that affected renderings.
This is to bring the screenshots up-to-date and resolve issues with Travis.