Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project notes #834

Merged
merged 4 commits into from
Sep 11, 2015
Merged

Fix project notes #834

merged 4 commits into from
Sep 11, 2015

Conversation

jaclynperrone
Copy link
Contributor

Resolves #728

Review on Reviewable

@ihodes
Copy link
Member

ihodes commented Sep 10, 2015

LGTM pending green!

Do you know why the non-examine page screenshots changed?

@jaclynperrone
Copy link
Contributor Author

@ihodes thanks!

Unfortunately, I have no idea :( They looked the same to me. The only difference I saw in webdiff was the file size.

@ihodes
Copy link
Member

ihodes commented Sep 10, 2015

😢 No pixel difference at all (hit "p" in webdiff)?

@jaclynperrone
Copy link
Contributor Author

@ihodes: Looks like some have a different time: http://screencast.com/t/dcheUz3Fx
I'll recheck the tests.

jaclynperrone added a commit that referenced this pull request Sep 11, 2015
@jaclynperrone jaclynperrone merged commit 4a2dd7a into master Sep 11, 2015
@jaclynperrone jaclynperrone deleted the fix-project-notes branch September 24, 2015 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants