New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resurface worker status #838
Conversation
if (value) { | ||
return ( | ||
<span className={`linked-bam ${cssClass}`} title={title} key={path.join('-')}> | ||
<span className={`${cssClass}`} title={title} key={path.join('-')}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`${cssClass}` => cssClass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
Looks good to me--a few comments to be addressed, but the approach is good. 👍 |
{path: ['tumor_bam' , 'name'], title: 'Tumor BAM' }, | ||
{path: ['normal_bam', 'name'], title: 'Normal BAM' }, | ||
]; | ||
var run_bams = labelSpecs.map( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run_bams
=> runBams
Looks good--one minor comment & you're good to merge. |
36cb876
to
f74354c
Compare
This PR does a couple things: