Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSL.pipe #53

Closed
wants to merge 3 commits into from
Closed

EDSL.pipe #53

wants to merge 3 commits into from

Conversation

smondet
Copy link
Member

@smondet smondet commented Mar 8, 2017

This was possible but very heavy.

let (||>) left right =(* was *)
    output_as_string left >> right

which is fine but interleaves pipes with conversions to Genspio's string representation.

The "in-language" solution is much more efficient.

@smondet smondet self-assigned this Mar 8, 2017
@smondet smondet requested a review from ihodes March 8, 2017 00:41
@smondet smondet changed the base branch from master to cli-parsing-doc March 8, 2017 00:42
We hit again the fact that `sed` has undefined behavior when there is no `\n`.
Copy link
Member

@ihodes ihodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smondet added a commit that referenced this pull request Mar 14, 2017
@smondet
Copy link
Member Author

smondet commented Mar 14, 2017

Merged into master.

@smondet smondet closed this Mar 14, 2017
@smondet smondet deleted the edsl-pipe branch July 12, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants