Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement cleanup #3

Open
timodonnell opened this issue Dec 22, 2016 · 1 comment
Open

implement cleanup #3

timodonnell opened this issue Dec 22, 2016 · 1 comment

Comments

@timodonnell
Copy link
Member

Kubeface writes a bunch of stuff to the bucket. After a computation has succeeded, we'll usually want to get rid of these.

The user should call client.cleanup() after their script has completed successfully. This should:

  • delete task input bucket items
  • delete task output buket items
  • rename the job status page from active:xxx to completed:xxx
  • delete all kubernetes pods that were created by the client (they are in a "completed" state and do not show up if you just run kubectl get pods without the -a flag)

Rationale for not doing this automatically is that the script may crash later on, and we want to pick up and use previously run tasks in that case. Only the user knows if the overall script has completed successfully.

Additionally, we should implement a kubeface-cleanup command that takes a job name (or cache key?) and does the cleanup for it.

Finally, we should maybe implement a __del__ method in the Client that prints out a message if the client is garbage collected without doing a cleanup, telling the user the kubeface-cleanup command to run to do the cleanup.

@timodonnell timodonnell mentioned this issue Jan 3, 2017
@timodonnell
Copy link
Member Author

We should also cleanup broadcasts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant