tests pass

hammerlab · Mar 5, 2021 · 1bb6085 · 1bb6085
1 parent 3a24ae6
commit 1bb6085
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/src/main/viz/CoverageCache.js b/src/main/viz/CoverageCache.js
@@ -102,7 +102,7 @@ class CoverageCache<T: (Alignment | Feature)> {
         this.refToCounts[utils.altContigName(range.contig)] ||
         {};
 
-    var max = 10; // minimum coverage
+    var max = 0; // minimum coverage
     for (var i = range.start(); i < range.stop(); i++) {
       if (bins[i] != undefined) {
         if (bins[i].count > max) {

diff --git a/src/main/viz/CoverageTrack.js b/src/main/viz/CoverageTrack.js
@@ -59,7 +59,7 @@ class CoverageTiledCanvas extends TiledCanvas {
 
   yScaleForRef(bottomPadding: number, topPadding:number): (y: number) => number {
     return scale.linear()
-      .domain([this.maxCoverage, 0])
+      .domain([Math.max(10, this.maxCoverage), 0]) // minimum coverage = 10
       .range([bottomPadding, this.height - topPadding])
       .nice();
   }

diff --git a/src/test/viz/CoverageCache-test.js b/src/test/viz/CoverageCache-test.js
@@ -41,7 +41,7 @@ describe('CoverageCache', function() {
     expect(bins[800]).to.deep.equal({count: 2});
     expect(bins[850]).to.deep.equal({count: 2});
     expect(bins[851]).to.deep.equal({count: 1});
-    expect(cache.maxCoverageForRef('chr1')).to.equal(2);
+    expect(cache.maxCoverageForRange(new ContigInterval("chr1", 100, 900))).to.equal(2);
     done();
   });
 
@@ -61,7 +61,7 @@ describe('CoverageCache', function() {
     expect(bins[800]).to.deep.equal({count: 2});
     expect(bins[850]).to.deep.equal({count: 2});
     expect(bins[851]).to.deep.equal({count: 1});
-    expect(cache.maxCoverageForRef('chr1')).to.equal(2);
+    expect(cache.maxCoverageForRange(new ContigInterval('chr1', 100, 900))).to.equal(2);
     done();
   });
 
@@ -107,7 +107,7 @@ describe('CoverageCache', function() {
     expect(bins[18]).to.deep.equal({count: 3});
     expect(bins[19]).to.deep.equal({count: 2});
     expect(bins[20]).to.deep.equal({count: 1});
-    expect(cache.maxCoverageForRef('chr1')).to.equal(6);
+    expect(cache.maxCoverageForRange(new ContigInterval('chr1',10,16))).to.equal(6);
 
     // Now change the reference
     letter = 'C';
@@ -117,7 +117,7 @@ describe('CoverageCache', function() {
     expect(bins[12]).to.deep.equal({count: 3, ref: 'C', mismatches: {A: 2}});
     expect(bins[15]).to.deep.equal({count: 6, ref: 'C', mismatches: {A: 4, T: 1, G: 1}});
     expect(bins[17]).to.deep.equal({count: 4, ref: 'C', mismatches: {A: 2}});
-    expect(cache.maxCoverageForRef('chr1')).to.equal(6);
+    expect(cache.maxCoverageForRange(new ContigInterval('chr1',1,20))).to.equal(6);
     done();
   });
 

diff --git a/src/test/viz/CoverageTrack-test.js b/src/test/viz/CoverageTrack-test.js
@@ -195,11 +195,11 @@ describe('CoverageTrack', function() {
       // These are the objects being used to draw labels
       var labelTexts = findCoverageLabels();
       expect(labelTexts[0].label).to.equal('0X');
-      expect(labelTexts[labelTexts.length-1].label).to.equal('1X');
+      expect(labelTexts[labelTexts.length-1].label).to.equal('10X');
 
       // Now let's test if they are actually being put on the screen
       var texts = callsOf(testDiv, '.coverage', 'fillText');
-      expect(texts.map(t => t[1])).to.deep.equal(['0X', '1X', '1X']);
+      expect(texts.map(t => t[1])).to.deep.equal(['0X', '5X', '10X']);
     });
 
   });