Skip to content

Commit

Permalink
Cleanup for review
Browse files Browse the repository at this point in the history
  • Loading branch information
danvk committed Nov 10, 2015
1 parent d823256 commit 355b9fe
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/main/Menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ type MenuItem = {
type Props = {
header: string;
items: Array<MenuItem|'-'>;
onSelect: (key: string)=>void;
onSelect: (key: string) => void;
};

class Menu extends React.Component<{}, Props, void> {
Expand Down
6 changes: 3 additions & 3 deletions src/main/PileupTrack.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,8 @@ class PileupTrack extends React.Component {
cache: PileupCache;
tiles: TiledCanvas;
static defaultOptions: { viewAsPairs: boolean };
static getOptionsMenu: (options: Object)=>any;
static handleSelectOption: (key: string, oldOptions: Object)=> Object;
static getOptionsMenu: (options: Object) => any;
static handleSelectOption: (key: string, oldOptions: Object) => Object;

constructor(props: VizProps) {
super(props);
Expand Down Expand Up @@ -297,7 +297,7 @@ class PileupTrack extends React.Component {
componentDidUpdate(prevProps: any, prevState: any) {
var shouldUpdate = false;
if (this.props.options != prevProps.options) {
this.handleOptionsChange(prevProps.options, this.props.options);
this.handleOptionsChange(prevProps.options);
shouldUpdate = true;
}

Expand Down
1 change: 0 additions & 1 deletion src/main/Root.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ class Root extends React.Component {
}

handleSelectOption(trackKey: string, optionKey: string) {
console.log(trackKey, optionKey);
this.setState({settingsMenuKey: null});

var viz = this.props.tracks[Number(trackKey)].visualization;
Expand Down

0 comments on commit 355b9fe

Please sign in to comment.