Be more aggressive about minification #310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two things going on here:
-g [ envify ]
instead of-t [envify]
applies the transform globally (i.e. including to code innode_modules
), rather than just to our code. This means that it sets theNODE_ENV
variable inside of React.require
statements are removed.These combine to shrink React pretty dramatically, since all the dev-mode code can be stripped.
∆ = 58,611 bytes (13%)
Looking at the source map, most of the difference is coming from React:
∆ = 67,419 bytes (33%)
Closes #307
* the dropped files are: