Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigBed parser #38

Merged
merged 4 commits into from
Mar 16, 2015
Merged

bigBed parser #38

merged 4 commits into from
Mar 16, 2015

Conversation

danvk
Copy link
Collaborator

@danvk danvk commented Mar 14, 2015

There are a few things happening here:

  • I've switched to using jBinary for parsing data structures. This eliminates the need for ReadableView and allows formats to be specified more declaratively.
  • I require an HTTP server for running tests. This facilitates using test data files and eliminates the need to mock XHRs (so the FakeXHR class can be deleted).
  • I've written a spec and parser for bigBed format with tests.

Fixes #27

Review on Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+4.42%) to 69.23% when pulling a2e43f3 on bigbed into a2f4298 on master.

@ihodes
Copy link
Member

ihodes commented Mar 16, 2015

LGTM!

ihodes added a commit that referenced this pull request Mar 16, 2015
@ihodes ihodes merged commit 82cbe9f into master Mar 16, 2015
@danvk danvk deleted the bigbed branch March 19, 2015 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support BigBed sources
3 participants