Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1-based coords in GeneTrack #394

Merged
merged 2 commits into from
Nov 30, 2015
Merged

Use 1-based coords in GeneTrack #394

merged 2 commits into from
Nov 30, 2015

Conversation

danvk
Copy link
Collaborator

@danvk danvk commented Nov 23, 2015

Fixes #60 (an old issue!)

I'll update the screenshots once some of the other PRs make it in. The diffs are exactly what you'd expect.

Review on Reviewable

@armish
Copy link
Member

armish commented Nov 24, 2015

👍


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@danvk
Copy link
Collaborator Author

danvk commented Nov 30, 2015

I updated the screenshots to reflect this change. I'm not sure why the scrollbar appears/disappears as I move between laptops.

danvk added a commit that referenced this pull request Nov 30, 2015
Use 1-based coords in GeneTrack
@danvk danvk merged commit 404f6c6 into master Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants