Disabled scrolling to negative regions #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,6 +50,10 @@ class Root extends React.Component { | |||
| } | |||
|
|
|||
| handleRangeChange(newRange: GenomeRange) { | |||
| // Do not propigate negative ranges | |||
| if (newRange.start < 0) { | |||
There was a problem hiding this comment.
thanks for this change, @akmorrow13!
Do you think this would better behave in terms of the UI if we do newRange.start = 0 instead of just doing nothing (i.e. return)?
|
Good call @armish . I have made those updates to now set the start to 0 if it is negative. |
|
@akmorrow13: cool - thanks for the fix! Will make a minor release with this fix in a minute 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is