Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed collapsed zoom button bug in Electron. #442

Closed
wants to merge 1 commit into from
Closed

Fixed collapsed zoom button bug in Electron. #442

wants to merge 1 commit into from

Conversation

chgibb
Copy link

@chgibb chgibb commented Nov 4, 2016

Under Electron "+" and "-" do not render on the zoom in and out buttons. This addresses this. Not tested for breakage in browser.


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 91.608% when pulling 0e70359 on chgibb:master into 0182b22 on hammerlab:master.

Copy link
Member

@armish armish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this does break the browser view
doubles

That said, I am curious why those don't show up in your Electron app. I played around with that a few months ago and all was working fine:
https://github.com/armish/pileup.electron

Can you make sure the pileup.css is being loaded properly?

@chgibb
Copy link
Author

chgibb commented Nov 4, 2016

@armish I'll give it a look on Monday. Thanks for the quick reply!

@chgibb
Copy link
Author

chgibb commented Nov 7, 2016

@armish other than this warning, there's nothing in the console.

'CanvasRenderingContext2D.webkitImageSmoothingEnabled' is deprecated. Please use 'CanvasRenderingContext2D.imageSmoothingEnabled' instead.

Do you know what the default search path is for pileup.css? I'm requiring the dist/pileup.js file generated by npm run build through browserify.

@chgibb
Copy link
Author

chgibb commented Nov 7, 2016

@armish poking through your pileup.electron repo I figured out the path. Thanks for the feedback!

@chgibb chgibb closed this Nov 7, 2016
@armish
Copy link
Member

armish commented Nov 8, 2016

@chgibb: glad that old hackathon project proved useful :P

By the way, really curious to learn more about your tool at some point when you think that is ready to share. It is always fun to see pileup.js in action.

@chgibb
Copy link
Author

chgibb commented Nov 9, 2016

@armish looking forward to sharing as it progresses :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants