Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo/race condition #49

Merged
merged 4 commits into from
Mar 19, 2015
Merged

Fix typo/race condition #49

merged 4 commits into from
Mar 19, 2015

Conversation

danvk
Copy link
Collaborator

@danvk danvk commented Mar 19, 2015

This was causing the gene track to render on initial page load only ~50% of the time.

Linting would have caught this (see #39)

Review on Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.48% when pulling c1ef2c4 on gene-lineup into a02c908 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.43%) to 67.91% when pulling db8a39b on gene-lineup into a02c908 on master.

danvk added a commit that referenced this pull request Mar 19, 2015
@danvk
Merge pull request #49 from hammerlab/gene-lineup
2460d98 
Fix typo/race condition
@danvk danvk merged commit 2460d98 into master Mar 19, 2015
@danvk danvk deleted the gene-lineup branch March 19, 2015 22:35
@danvk danvk mentioned this pull request Mar 20, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danvk @coveralls