Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed phantomjs dependency #518

Merged
merged 5 commits into from
May 1, 2019

Conversation

akmorrow13
Copy link
Collaborator

No description provided.

@akmorrow13
Copy link
Collaborator Author

Addresses #517 and #503

@akmorrow13
Copy link
Collaborator Author

akmorrow13 commented Apr 29, 2019

TODOs:

  • Test with node 12.0.0

  • fix coverage

@coveralls
Copy link

coveralls commented Apr 29, 2019

Coverage Status

Coverage increased (+0.03%) to 91.456% when pulling f740cbf on akmorrow13:remove_phantomjs into 86a841b on hammerlab:master.

@akmorrow13
Copy link
Collaborator Author

ping @piotr-gawron maybe this will fix issue #517

@piotr-gawron
Copy link
Contributor

Dear @akmorrow13,
I checked it and it works fine: everything installed without problem and all tests are green (checked on both 12.0.0 and 10.15.3).

Since you decided to remove deprecated phantomejs do you also plan to upgrade other libraries? simple

npm audit

reports found 42 vulnerabilities (9 low, 22 moderate, 10 high, 1 critical) in the dependencies...

@akmorrow13
Copy link
Collaborator Author

Thanks for testing @piotr-gawron! Removing and replacing some of these libraries broke different aspects of pileup.js, so I will not be addressing them here. PRs for fixes are always welcome, however!

@akmorrow13 akmorrow13 merged commit 406edcb into hammerlab:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants