Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after changing pythonjs to mocha-headless-chrome grep on unit tests stopped working #519

Merged

Conversation

piotr-gawron
Copy link
Contributor

After changing pythonjs to mocha-headless-chrome there was no way to run single test from the console.

For instance this call executed all unit tests, but shouldn't.

npm run test -- --grep=pileuputils

This PR restores grep functionality when running unit tests.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.456% when pulling f2d8fc2 on piotr-gawron:mocha-headless-chrome-grep-issue into 406edcb on hammerlab:master.

@akmorrow13
Copy link
Collaborator

Thanks for the catch, @piotr-gawron! I tested it out and it works great. Thanks for the contribution!

@akmorrow13 akmorrow13 merged commit e99848d into hammerlab:master May 2, 2019
@piotr-gawron piotr-gawron deleted the mocha-headless-chrome-grep-issue branch May 2, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants