Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let users view past the end of contigs #543

Merged
merged 6 commits into from
Feb 16, 2021

Conversation

akmorrow13
Copy link
Collaborator

@akmorrow13 akmorrow13 commented Feb 11, 2021

Previously, the browser could scroll past the end of contigs. We now grab the number of bases from the current contig being viewed, and restrict viewing to this region. This required a substantial rebase of viz tests, that previously used a twobit file with short contigs. We now use a fake twobit file so all regions can be accessed during testing.

TODOs:

  • fix slider in controls.js

@coveralls
Copy link

coveralls commented Feb 12, 2021

Coverage Status

Coverage increased (+0.5%) to 91.32% when pulling cabe15c on akmorrow13:minor_fixes into 7cc3016 on hammerlab:master.

@akmorrow13 akmorrow13 merged commit 62a15bb into hammerlab:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants