Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to fetch real BAMs #69

Merged
merged 5 commits into from
Apr 15, 2015
Merged

Changes to fetch real BAMs #69

merged 5 commits into from
Apr 15, 2015

Conversation

danvk
Copy link
Collaborator

@danvk danvk commented Apr 15, 2015

This includes a few fixes needed to fetch reads from "real" (100+GB) BAM files:

  • Header size is computed using the BAI file. If it's >64k, this is essential.
  • BAM files are read in 128k chunks until reads past the query interval are found. This matches the logic in IGV and can dramatically reduce the number of network requests required.
  • Fix a tricky issue with >> vs >>> in parsing virtual offsets.

Review on Reviewable

BamFile now uses a strategy of fetching 128k chunks until it gets to a
read that it doesn’t care about. This matches IGV and dramatically
reduces the number of network requests required.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.42%) to 92.81% when pulling 338f843 on real-bams into 1edb037 on master.

danvk added a commit that referenced this pull request Apr 15, 2015
@danvk danvk merged commit cbadd5e into master Apr 15, 2015
@danvk danvk mentioned this pull request Apr 15, 2015
@danvk danvk deleted the real-bams branch June 22, 2015 16:21
Georgehe4 pushed a commit to Georgehe4/pileup.js that referenced this pull request Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants