Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop at end of BAM files #89

Merged
merged 1 commit into from
Apr 22, 2015
Merged

Fix infinite loop at end of BAM files #89

merged 1 commit into from
Apr 22, 2015

Conversation

danvk
Copy link
Collaborator

@danvk danvk commented Apr 22, 2015

Fixes #88

There were two issues here:

  • First, a >= vs > error when determining if a buffer had enough bytes left to parse a read.
  • An infinite loop when there were no bytes left to scan.

Review on Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 93.36% when pulling d4ef773 on 88-infinite-loop into 1ce2aca on master.

danvk added a commit that referenced this pull request Apr 22, 2015
@danvk
Merge pull request #89 from hammerlab/88-infinite-loop
3cfc8db 
Fix infinite loop at end of BAM files
@danvk danvk merged commit 3cfc8db into master Apr 22, 2015
@danvk danvk deleted the 88-infinite-loop branch June 22, 2015 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite Loop in BAM parser
2 participants
@danvk @coveralls