Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of missing progression data #1

Open
arahuja opened this issue Sep 16, 2016 · 5 comments
Open

Fix handling of missing progression data #1

arahuja opened this issue Sep 16, 2016 · 5 comments

Comments

@arahuja
Copy link
Contributor

arahuja commented Sep 16, 2016

For now pfs and os are just zero-d when not available, though we should have proper na handling.

See hammerlab/cohorts#46

@jburos
Copy link
Member

jburos commented Sep 16, 2016

I'm curious why these would ever be NA - the XML version of the clin data has a field last_contact_days_to, for example, which can be used to populate these values. If they are actually unknown, then a value of 0 seems appropriate. Not sure if there an analogous field available from the cases endpoint of the API.

In general seems likely we will want/need a few post-processing steps for clin data.

@arahuja
Copy link
Contributor Author

arahuja commented Sep 16, 2016

I saw a few cases where last_contact_days_to or I think it's called days_to_last_follow_up or something was also None. There was also a case where this was longer than the OS which was odd.

@jburos
Copy link
Member

jburos commented Sep 16, 2016

Interesting. I see a field called followup_lost_to which may also be informative?

Perhaps we should look at annotations for these use cases, to see if they can help reconcile the issues.

@hammer
Copy link
Member

hammer commented Dec 17, 2016

@jburos what is this blocked on?

@jburos
Copy link
Member

jburos commented Dec 17, 2016

@hammer The blocking issue is hammerlab/cohorts#46 (cohorts doesn't currently support unknown progression/mortality status).

@jburos jburos removed their assignment Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants