Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NA PFS or OS #46

Open
arahuja opened this issue May 27, 2016 · 2 comments
Open

Support NA PFS or OS #46

arahuja opened this issue May 27, 2016 · 2 comments

Comments

@arahuja
Copy link
Contributor

arahuja commented May 27, 2016

Maybe out of scope for this project, but for TCGA data it would be useful to support PFS or OS being set to NaN. Right now, this gives an error because of the PFS <= OS assertion

@tavinathanson
Copy link
Member

I think that's fair game. cohorts seems to support several random use cases; e.g. it's even useful for both genetic data and purely clinical data. Eventually, instead of None in a million places, it might be nice to clearly delineate some categories of use (and eventually split them out). But None in a lot of places seems fine for now.

@jburos
Copy link
Member

jburos commented Oct 24, 2016

This will actually be important for the RCC analysis, where we expect a subset of patients to have temporarily unknown survival status until time of unblinding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants