Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for Kanagawa #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

at-wat
Copy link

@at-wat at-wat commented Mar 5, 2019

Original js seems valid in Hyogo prefecture at this moment.
This PR adds compatibility for Kanagawa prefecture.

If you like it, I will add README for this.
Keeping the minimal implementation of this repo for Hyogo would be also a nice choice:)

@nunukim
Copy link

nunukim commented Mar 5, 2019

+1 for keeping this repo simple for Hyogo.
Your implementation seems too complecated to be understood by NHK as well as prefectures' police.

@hamukazu
Copy link
Owner

hamukazu commented Mar 6, 2019

Thanks for interesting idea!
But this capability looks overkill from viewpoint of the original concept. I recommend to make your own fork to implement this. I really appreciate your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants