Merge pull request #18 from hanami/feature/pagination

Add pagination gem for show page

Gemfile

@@ -13,6 +13,8 @@ gem 'slim'
 gem 'hanami-bootstrap', '0.4'
 gem 'sass'
 
+gem 'hanami-pagination'
+
 # api
 gem 'hanami-serializer', github: 'davydovanton/hanami-serializer'
 

Gemfile.lock

@@ -93,6 +93,8 @@ GEM
       hanami-utils (~> 1.0)
       rom-repository (~> 1.3)
       rom-sql (~> 1.2)
+    hanami-pagination (0.1.0)
+      hanami-model (~> 1.0)
     hanami-router (1.0.0)
       hanami-utils (~> 1.0)
       http_router (= 0.11.2)
@@ -223,6 +225,7 @@ DEPENDENCIES
   hanami (= 1.0.0)
   hanami-bootstrap (= 0.4)
   hanami-model (= 1.0.0)
+  hanami-pagination
   hanami-serializer!
   hiredis
   mock_redis

apps/api/controllers/contributors/show.rb

@@ -13,7 +13,7 @@ def call(params)
     def responce_hash(contributor)
       return ERROR_RESPONCE unless contributor
 
-      commits = CommitRepository.new.all_for_contributor(contributor.id).map(&:to_h)
+      commits = CommitRepository.new.all_for_contributor(contributor.id).to_a.map(&:to_h)
 
       {
         status: :ok,

apps/web/controllers/contributors/show.rb

@@ -1,11 +1,13 @@
 module Web::Controllers::Contributors
   class Show
     include Web::Action
+    include Hanami::Pagination::Action
+
     expose :contributor, :commits
 
     def call(params)
       @contributor = ContributorRepository.new.find_by_github(params[:id])
-      @commits = CommitRepository.new.all_for_contributor(@contributor.id)
+      @commits = all_for_page(CommitRepository.new.all_for_contributor(@contributor.id))
     end
   end
 end

apps/web/templates/contributors/show.html.slim

@@ -7,3 +7,17 @@ table.table.table-hover
       td = link_to commit.title, commit.url, target: '_blank'
       td = project_name(commit)
 
+- if show_pagination?
+  nav aria-label="Page navigation"
+    ul class="pagination"
+      - if pager.prev_page
+        li
+          a href="#{prev_page_url}" aria-label="Previous"
+            span aria-hidden="true" «
+      - pager.pages_range.each do |i|
+        li class="#{active_class(i)}"
+          a href="/contributors/#{contributor.github}/?page=#{i}" = i
+      - if pager.next_page
+        li
+          a href="#{next_page_url}" aria-label="Next"
+            span aria-hidden="true" »

apps/web/views/contributors/show.rb

@@ -1,6 +1,11 @@
 module Web::Views::Contributors
   class Show
     include Web::View
+    include Hanami::Pagination::View
+
+    def active_class(page)
+      'active' if pager.current_page?(page)
+    end
 
     def project_name(commit)
       matcher = commit.url.match(%r{github.com/hanami/([\w.]+)/})
@@ -10,5 +15,9 @@ def project_name(commit)
     def title
       "Commits for #{contributor.github}"
     end
+
+    def show_pagination?
+      pager.pager.total_pages > 1
+    end
   end
 end

config/initializers/enable_pagination.rb

@@ -0,0 +1 @@
+CommitRepository.enable_pagination!

lib/contributors/repositories/commit_repository.rb

@@ -1,5 +1,5 @@
 class CommitRepository < Hanami::Repository
   def all_for_contributor(contributor_id)
-    commits.where(contributor_id: contributor_id).to_a
+    commits.where(contributor_id: contributor_id)
   end
 end

spec/contributors/services/add_new_commits_spec.rb

@@ -15,7 +15,7 @@
     VCR.use_cassette("commits") do
       described_class.new.call
 
-      commits = commit_repo.all_for_contributor(contributor.id)
+      commits = commit_repo.all_for_contributor(contributor.id).to_a
 
       expect(commits).not_to be_empty
       expect(commits.first.url).to be