Set default security-related headers for application actions #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies sensible defaults for security-related headers previously configurable via an application’s `config.security`.
Closed
timriley
force-pushed
the
enhancement/unstable/set-default-security-headers
branch
from
98dfb83
to
ecdaf85
Compare
timriley
deleted the
enhancement/unstable/set-default-security-headers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Actions are used within the context of a full Hanami application, by default they will now serve a range of security-related headers by default (
X-Frame-Options,X-Content-Type-Options,X-XSS-Protection,Content-Security-Policy). This matches the behaviour established in Hanami 1.x.Previously, these headers were independently configurable via the application's
config.securitynamespace, e.g.config.security.x_frame_options = "SAMEORIGIN". Instead of following this approach, we've instead just configured the existingdefault_headershash with these header values automatically. This is a simpler, more maintainable approach, and just as easy to understand to users, who would already be familiar with the header values they're looking to configure.