Add the action instance to the request environment #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I created a [new topic] on the Hanami Discourse about improving the AppSignal APM instrumentation. To group requests, we would like to know what action it took place in. This information is currently not available in the request environment. For us, the easiest would be to access the action instance. That gives us the class information and a way to access the `params_class` to fetch all the parameters of the request: query params and the body payload. This change adds the action instance on a new request environment key `hanami.action_instance`. [new topic]: https://discourse.hanamirb.org/t/questions-for-improving-the-appsignal-apm-integration-with-hanami-2/989/3 I had to update one test to not fail on the action instance being returned, which is not important for that spec I think. Closes hanami#445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new topic on the Hanami Discourse about improving the AppSignal APM instrumentation.
To group requests, we would like to know what action it took place in. This information is currently not available in the request environment.
For us, the easiest would be to access the action instance. That gives us the class information and a way to access the
params_classto fetch all the parameters of the request: query params and the body payload.This change adds the action instance on a new request environment key
hanami.action_instance.I had to update one test to not fail on the action instance being returned, which is not important for that spec I think.
Closes #445
Let me know what you think!