Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add actions-testing section #147

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Add actions-testing section #147

merged 5 commits into from
Nov 22, 2022

Conversation

swilgosz
Copy link
Sponsor Member

@swilgosz swilgosz self-assigned this Nov 21, 2022
@solnic
Copy link
Member

solnic commented Nov 22, 2022

@swilgosz thanks for working on this, I decided to take over and change it though because it was too late to do the PR review ping-pong.

andrewcroome
andrewcroome approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@andrewcroome andrewcroome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor typos - I could be doing something wrong locally when replicating the test by the sounds.

content/v2.0/actions/testing.md Outdated Show resolved Hide resolved
content/v2.0/actions/testing.md Outdated Show resolved Hide resolved
content/v2.0/actions/testing.md Outdated Show resolved Hide resolved
content/v2.0/actions/testing.md Outdated Show resolved Hide resolved
content/v2.0/actions/testing.md Outdated Show resolved Hide resolved
content/v2.0/actions/testing.md Outdated Show resolved Hide resolved
timriley and others added 2 commits November 22, 2022 19:45
@timriley @andrewcroome
Update content/v2.0/actions/testing.md
2c27806 
Co-authored-by: Andrew Croome <andrewcroome@gmail.com>
@timriley
Update from Andrew's feedback
dccd596
@timriley timriley merged commit 1083cf0 into main Nov 22, 2022
@timriley timriley deleted the docs/311-acions-testing branch November 22, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewcroome andrewcroome andrewcroome approved these changes

@timriley timriley Awaiting requested review from timriley

Assignees

@swilgosz swilgosz

Labels
documentation ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swilgosz @solnic @timriley @andrewcroome