Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update form helper documentation #156

Merged
merged 1 commit into from
Mar 9, 2016
Merged

Conversation

davydovanton
Copy link
Member

Add missing helper tags and inputs. Add documentation link to each heller. Add "Pass A Value" and "Share Code Between Views" examples.

@@ -201,6 +203,140 @@ Developers can customize attack handling.
</form>
```

### Pass A Value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davydovanton All this description was kept out with intention. This is overwhelming at the first glance and it's subject to change. Can you please rollback all this part? Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, no problem. I added this part because I am often asked about share form code between views. What you think can we do something to help with this issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davydovanton I think that there is still room for improvement in views. By looking at this updated guide one may think "OMG, should I use all this stuff to create a simple form?". Again, this looks overwhelming. The right thing to do is to try to improve the API, instead of offer this informations overload.

Add missing helper tags and inputs. Add documentation
link to each heller.
@davydovanton
Copy link
Member Author

@jodosha deleted unnecessary examples

@jodosha
Copy link
Member

jodosha commented Mar 9, 2016

@davydovanton Thank you. Merging 👍

jodosha added a commit that referenced this pull request Mar 9, 2016
Update form helper documentation
@jodosha jodosha merged commit cad7671 into hanami:build Mar 9, 2016
@jodosha jodosha self-assigned this Mar 9, 2016
@davydovanton
Copy link
Member Author

🎉

@davydovanton davydovanton deleted the form-helper branch March 9, 2016 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants