Make web-specific gems optional #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hanami-controller, hanami-router, and hanami-view from the Gemfile, instead allowing these gems to be included in the Gemfiles of generated Hanami applications. This allows Hanami to be used more gracefully as a non-web application framework, since it will no longer be pulling in unnecessary dependencies for that case.
timriley
force-pushed
the
enhancement/unstable/web-gems-optional
branch
from
8981353
to
b4bfa99
Compare
jodosha
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hanami-controller, hanami-router, and hanami-view from the gemspec, instead allowing these gems to be included in the Gemfiles of generated Hanami applications.
This allows Hanami to be used more gracefully as a non-web application framework, since it will no longer be pulling in unnecessary dependencies for that case.