Remove old integration tests #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We removed legacy integration tests, so we're free to retake the word
|
Thanks for doing this, @waiting-for-dev! I still think there might be some value in combing through these legacy integration tests and making sure we have sufficient coverage for our 1.0->2.0 upgrades, but I think that can still reasonably be done by looking at the legacy tests from the 1.x branches, rather than continuing to keep them here in the main branch. Happy for you to merge whenever. |
timriley
approved these changes
Aug 31, 2022
waiting-for-dev
deleted the
waiting-for-dev/remove_old_integration_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're too far away from the current setup, so we ditch them and rename
"new_integration" to "integration".