Allow custom loggers #768

binarylogic · 2017-04-11T23:49:16Z

Currently Hanami only takes an array of arguments that get passed to the Hanami::Logger class. This change allows the use of a custom Logger by passing a single object during configuration. For example:

Hanami.configure do
  environment :production do
    logger Timber::Logger.new(STDOUT)
  end
end

This change was prompted in order to install the Timber logger which handles capturing context and structure automatically.

…751

* Generate empty `lib/<project-name>.rb` file * Generate new projects with empty module in `lib/<project_name>.rb` Example: $ hanami new cool_project $ cd cool_project $ cat lib/cool_project.rb module CoolProject end

…unning it in a separated process

davydovanton

I like this idea. But I have some little issues and what to discuss about it.

@hanami/core WDYT?

davydovanton · 2017-04-12T06:39:00Z

lib/hanami/components/components.rb

@@ -28,7 +28,13 @@ module Components # rubocop:disable Metrics/ModuleLength
      end

      resolve do |configuration|
-        Hanami::Logger.new(Hanami.environment.project_name, *configuration.logger) unless configuration.logger.nil?
+        if configuration.logger.is_a?(Array)
+          if configuration.logger.length == 1 && configuration.logger[0].is_a?(::Logger)


maybe just configuration.logger.fist.is_a?(::Logger)?

and are you sure that this code will work with other loggers (for example logging)?

Yes, I don't see any reason it wouldn't unless the internal usage of the logger in Hanami deviates from the standard ::Logger interface. Otherwise, this should work great.

maybe just configuration.logger.fist.is_a?(::Logger)?

Done

binarylogic · 2017-04-12T18:49:15Z

Yes, please let me know the consensus. Hanami is so refreshing to work with in comparison to alternatives, so it's no surprise we have multiple customers at @timberio that are using it. But they can't unless we patch how the logger is set. Moreover, there are quite a few other Logging alternatives (as you pointed out), and restricting everyone to ::Logger feels too opinionated in my opinion.

binarylogic · 2017-04-12T18:50:17Z

Also, do you mind expanding on the issues that concern you? Maybe I can help or write code that addresses them?

mereghost

Albeit not being a fan of double ifs, I have no suggestion to refactor that, so.... LGTM

binarylogic · 2017-04-17T15:30:06Z

Thanks! Are we good to ship it?

mereghost · 2017-04-17T15:38:49Z

@davydovanton any other non-addressed points?

jodosha

@binarylogic Hi and thanks for this PR. LGTM 👍

Side note: I don't like that if, but it seems the easiest way to implement this feature so .

@binarylogic Would you be so kind to add the documentation part of this on hanami/hanami.github.io repository, so it will appear here: http://hanamirb.org/guides/projects/logging/

Tnx! 👍

jodosha · 2017-04-25T14:55:02Z

@davydovanton Please review again an let us to know WDYT. Thanks.

davydovanton

great work 👏

binarylogic · 2017-04-25T18:56:42Z

Would you be so kind to add the documentation part of this on hanami/hanami.github.io repository, so it will appear here:

@jodosha absolutely, I'll try to get on it today or tomorrow

mereghost · 2017-04-25T19:10:10Z

As everyone is happy and merry, @binarylogic could you rebase it on hanami:develop and push it, so I can merge it?

jodosha · 2017-04-25T19:35:24Z

@mereghost by clicking on "Squash and merge" should solve the rebase problem, right?

mereghost · 2017-04-25T19:53:01Z

@jodosha It seems it's not an interactive squash, so I can't discard commits. >.<

binarylogic · 2017-05-17T21:10:12Z

Hey guys, any update here? It appears the branch has no conflicts at the moment.

jodosha and others added 11 commits March 20, 2017 11:20

Authors in gemspec

b119680

Reuse old mailer configuration when code reloading is active. Closes #…

78840d4

…751

Disconnect Hanami::Model directly inside Hanami.boot (#760)

fa5c98f

Allow mailer settings to be evaluated multiple times (#761)

9e6fc5a

Generate empty lib/<project-name>.rb file (#762)

7223708

* Generate empty `lib/<project-name>.rb` file * Generate new projects with empty module in `lib/<project_name>.rb` Example: $ hanami new cool_project $ cd cool_project $ cat lib/cool_project.rb module CoolProject end

Prepare for v1.0.0.rc1

726b86f

Isolate global state (env vars) for a mailer configuration test, by r…

f4d663f

…unning it in a separated process

Pass arbitrary arguments to logger setting in config/environment.rb

47a9bc8

Prepare for v1.0.0

aec069b

Let Hanami.boot to return nil

646a7bd

Allow custom loggers

8b83b5e

davydovanton requested changes Apr 12, 2017

View reviewed changes

Simplify logger checking if statement

6d1c52b

mereghost approved these changes Apr 12, 2017

View reviewed changes

mereghost changed the base branch from master to develop April 17, 2017 16:04

jodosha assigned mereghost Apr 25, 2017

jodosha added this to the v1.1.0 milestone Apr 25, 2017

jodosha approved these changes Apr 25, 2017

View reviewed changes

jodosha mentioned this pull request Apr 25, 2017

Custom logger #738

Closed

jodosha added the enhancement label Apr 25, 2017

davydovanton approved these changes Apr 25, 2017

View reviewed changes

mereghost merged commit 36d6eab into hanami:develop Jun 2, 2017

binarylogic mentioned this pull request Jun 2, 2017

Add official hanami support vectordotdev/timber-ruby#94

Closed

binarylogic mentioned this pull request Aug 22, 2017

Add custom logger example hanami/hanami.github.io#366

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow custom loggers #768

Allow custom loggers #768

binarylogic commented Apr 11, 2017 •

edited

davydovanton left a comment

davydovanton Apr 12, 2017

davydovanton Apr 12, 2017

binarylogic Apr 12, 2017

binarylogic Apr 12, 2017

binarylogic commented Apr 12, 2017 •

edited

binarylogic commented Apr 12, 2017

mereghost left a comment •

edited

binarylogic commented Apr 17, 2017 •

edited

mereghost commented Apr 17, 2017

jodosha left a comment

jodosha commented Apr 25, 2017

davydovanton left a comment

binarylogic commented Apr 25, 2017

mereghost commented Apr 25, 2017 •

edited

jodosha commented Apr 25, 2017

mereghost commented Apr 25, 2017

binarylogic commented May 17, 2017

Allow custom loggers #768

Allow custom loggers #768

Conversation

binarylogic commented Apr 11, 2017 • edited

davydovanton left a comment

Choose a reason for hiding this comment

davydovanton Apr 12, 2017

Choose a reason for hiding this comment

davydovanton Apr 12, 2017

Choose a reason for hiding this comment

binarylogic Apr 12, 2017

Choose a reason for hiding this comment

binarylogic Apr 12, 2017

Choose a reason for hiding this comment

binarylogic commented Apr 12, 2017 • edited

binarylogic commented Apr 12, 2017

mereghost left a comment • edited

Choose a reason for hiding this comment

binarylogic commented Apr 17, 2017 • edited

mereghost commented Apr 17, 2017

jodosha left a comment

Choose a reason for hiding this comment

jodosha commented Apr 25, 2017

davydovanton left a comment

Choose a reason for hiding this comment

binarylogic commented Apr 25, 2017

mereghost commented Apr 25, 2017 • edited

jodosha commented Apr 25, 2017

mereghost commented Apr 25, 2017

binarylogic commented May 17, 2017

binarylogic commented Apr 11, 2017 •

edited

binarylogic commented Apr 12, 2017 •

edited

mereghost left a comment •

edited

binarylogic commented Apr 17, 2017 •

edited

mereghost commented Apr 25, 2017 •

edited