Render 500 custom template if an exception happens in a view or template

[AlfonsoUceda]

This PR fixes #865

It will render the 500 custom template if an exception happens in a view or template, in addition it sets handle_exceptions to true by default, in controller level it was true for not in hanami application level, https://github.com/hanami/hanami/blob/master/lib/hanami/application_configuration.rb#L1272

[AlfonsoUceda]

@cveneziani this is a work in progress but it should render 500 page in production when an error happens, can you give it a try?

[cveneziani]

I confirm, it's working. I do have the 500 page on errors happening in the view or the template.

The only thing I'm missing is the bugtracker being notified for these errors.

[AlfonsoUceda]

Hi @cveneziani what bug error tracker are you using? I'd like to test it.

[cveneziani]

I'm using Bugsnag.
The tracker is notified for any action error but not for view or template errors.

[AlfonsoUceda]

Did you set bugsnag using this doc? https://docs.bugsnag.com/platforms/ruby/rack/ I ask this because I'll test using that

[cveneziani]

Yes exactly.
BTW if you want to have a look, it's here: nfilzi/housing-list@bc1bca5

[AlfonsoUceda]

For now I can only check the code since I don't have my laptop with me. We set 'rack.exception' and bugsnag middleware should notify but I'll debug an application when I come back, thanks @cveneziani

[cveneziani]

Thanks again.

[AlfonsoUceda]

@cveneziani where did you define Bugsnag::Rack middleware? in application.rb inside apps/APP folder? please try to move the middleware to config.ru:

require './config/environment'

use Bugsnag::Rack
run Hanami.app

[cveneziani]

I've defined the Bugsnag middleware in the application.rb, see here: nfilzi/housing-list@bc1bca5#diff-945ab852b87f99f59478ad5c2092a40bR93

I tried to move it within the config.ru and it's working.
Bugsnag is now being notified wherever the error is triggered: in the action, in the view or in the template.

Is it normal that it's not working (except for an error within an action) when the bug tracker is defined within the application?

What if I want to enable Bugsnag middleware only from within a specific app as explained here: http://hanamirb.org/guides/1.1/actions/rack-integration/#application-middleware ?

[AlfonsoUceda]

@cveneziani nop, it isn't normal and I'll try to fix that problem because as you said, you could add only in one app.

[cveneziani]

Thanks for the clarification :)

[AlfonsoUceda]

@cveneziani sorry for the late answer. In hanami 1.2.0 we support middlewares per application you will be able to add only bugsnag to one app or apps you want. I'll retest again this PR and make test passes. I'll come back to you shortly

[cveneziani]

Nice to hear. Thanks again :)

[jodosha]

@AlfonsoUceda This looks really good! 👏 💯