[WIP] Extract CLI generator #931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renamed from 'destination' to 'path', since a destination doesn't really make sense for something that's being deleted.
And rename some variables from 'destination' to 'path', since it's more accurate
Also fix the behavior for routes, where it'd say it 'inserted' the route when really it appended it. Either would be fine, but this is more accurate and simpler to implement.
cllns
force-pushed
the
extract-cli-generator
branch
from
c1c912f
to
910ca80
Compare
|
very good job @cllns it makes sense to extract this to CLI, for me it is ok :) Can you rebase this branch from |
|
Talking with @jodosha a little while ago, we decided this should be extracted more. Specifically, reading the templates should be extracted into So instead of: source = templates.find("README.md.erb")
destination = project.readme(context)
generator.create(source, destination, context)The API would be: destination = project.readme(context)
generator.create("README.md.erb", destination, context)Does that make sense? It's quite a bit more work on top of what's already in this PR. |
|
Removing milestone 1.3.0 because it isn't completed and is not a priority |
|
Closing as stale PR. @cllns Feel free to resume the work. |
Note: we'll get rid of @templates, in favor of using @Generator directly
It needs the other updated instance variable too, for now.
We can pass in just the name of the file, and the generator knows what to do with it now.
It's now just Hanami::CLI::Templates, too
The Command can find its own location for templates now, based on the command, so it's not necessary to specify an exact class.
|
Closing as stale initiative. @cllns Feel free to reopen, in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to extract to file generation functionality from this repo to
Hanami::CLI.A few reasons:
Hanami::CLIcan benefit from our work. They won't need to write their own file manipulation and output code.Hanami::CLIlevel, so all our specs for this repo can be plaintext without being muddied by a bunch of shell-code for colorizing (since we can disable colorizing for specs, and delegate the testing of that behavior toHanami::CLI's test suite).Hanami::CLI.cc @AlfonsoUceda @hanami/core
Some clean-up too:
I changed some variables names to
pathfromdestinationwhen there's only one page. It makes sense to havedestinationandsourcewhen they are two paths, but, for example,destinationdoesn't make sense for something we want to delete.The CLI said a route was
inserted, when really it wasappended. Either one works but it's simpler for the cade to just let it say the route was appended to the routes file.