-
-
Notifications
You must be signed in to change notification settings - Fork 153
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reliably parse query params from connection string (#485)
The previous regex used the match query options was incorrect since it only captured words (`\w+`) values from query params. This would cause params with values such as `&host=/path/to/my/socket` to be parsed as `nil`, which is incorrect and will cause pain on some hosting providers (i.e. Google Cloud requires a path to a socket). Parsing query params can be brittle, so we opt to let `CGI.parse` to do the heavy lifting since it is more battle-tested.
- Loading branch information
Showing
2 changed files
with
37 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters