Merge pull request #78 from lotus/ignore-blank-values-for-format-vali…

…dation Ignore blank values for format validation
hanami · Oct 29, 2015 · f0b9020 · f0b9020
2 parents a893bbb + ef3bb91
commit f0b9020
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/lotus/validations/attribute.rb b/lib/lotus/validations/attribute.rb
@@ -106,7 +106,7 @@ def acceptance
       # @since 0.2.0
       # @api private
       def format
-        _validate(__method__) {|matcher| @value.to_s.match(matcher) }
+        _validate(__method__) {|matcher| @value.to_s.match(matcher) } unless blank_value?
       end
 
       # Validates inclusion of the value in the defined collection.

diff --git a/test/format_validation_test.rb b/test/format_validation_test.rb
@@ -9,6 +9,14 @@
       validator.errors.must_be_empty
     end
 
+    # Bug https://github.com/lotus/validations/issues/77
+    it "is valid if has blank value" do
+      validator = FormatValidatorTest.new({name: ''})
+
+      validator.valid?.must_equal true
+      validator.errors.must_be_empty
+    end
+
     it "is valid if it respects given formats" do
       validator = FormatValidatorTest.new({name: 'Luca', age: '32'})