Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean Translation for Handlebars.js Documentation #145

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

Myunwoo
Copy link
Contributor

@Myunwoo Myunwoo commented May 23, 2024

Description:
This PR adds a complete Korean translation of the Handlebars.js documentation. The translated content includes all sections of the original documentation, ensuring that Korean-speaking developers can easily understand and utilize Handlebars.js.

Changes:
Added a new directory src/ko with all translated files.
Updated the main documentation page to include a link to the Korean version.

Checklist:
☑️ All translated files are included.
☑️ Links to the Korean documentation are correctly placed.
☑️ Reviewed for accuracy and completeness.

Thank you for considering this PR.

@papasmile
Copy link
Contributor

Awesome! Are there any Korean-speakers who can review out there?

@Myunwoo
Copy link
Contributor Author

Myunwoo commented May 25, 2024

Is there anyone who can review what I translated? If not, I can ask developers around me.

I'm curious about what process a review should take.

@papasmile
Copy link
Contributor

papasmile commented May 25, 2024

Hi, sure, it can be informal. Someone should proof-read and suggest any corrections, or say if everything looks good; more that one person would be even better :)

@Seongjunsim
Copy link

I have been asked to review a Korean translation document, and here are the results of my review.
In the markdown file, line breaks result in spaces being applied.
Therefore, line breaks should be applied where spaces are needed.

Here is an example:
src/ko/guide

  • 대 체됩니다 -> 대체됩니다
  • 이스케이프하지 않 습니다. -> 이스케이프하지 않습니다.
  • 이스케 이프되지 않도록 -> 이스케이프되지 않도록
  • 않 더라도 -> 않더라도
  • 템플 릿을 -> 템플릿을

src/ko/guide

  • 이는 표 현식이라고 -> 이는 표현식이라고

Apart from the spacing errors, there are no awkward parts in the translation.

@Myunwoo
Copy link
Contributor Author

Myunwoo commented May 28, 2024

@Seongjunsim Spacing error has been corrected. Thank you for your review.

@Myunwoo
Copy link
Contributor Author

Myunwoo commented May 29, 2024

/ko/index.md file
::: playground Live Demo → :::

The above contents

::: playground
Live Demo →
:::

If I commit and push with line breaks as shown above, it is saved without line breaks. What should I do? I need help.

@papasmile
Copy link
Contributor

@Myunwoo hm usually a local git client issue, try reading that one: https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings

@Myunwoo
Copy link
Contributor Author

Myunwoo commented May 30, 2024

@papasmile Tahnk you so much!
If the line break wasn't done properly, it was possible to solve the problem by adding two spaces at the end of the line.
I'll ask for a review again to see if there are any problems with my contribution.

@sungsuhan
Copy link

I reviewed the revised version. All translated sentences have been checked, including modifications to the demo button.
It doesn't look like a problem to me!

@jaylinski jaylinski self-requested a review June 5, 2024 21:46
@papasmile
Copy link
Contributor

thanks!

@papasmile papasmile merged commit a4a8cf0 into handlebars-lang:master Jun 5, 2024
1 check passed
@papasmile
Copy link
Contributor

Korean translation is now live at https://handlebarsjs.com/ko/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants