-
Notifications
You must be signed in to change notification settings - Fork 2k
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handlebars 4.5.0 results in an unmet peer dependency #1589
Comments
BTW, shouldn't |
Thanks so much for the quick reaction @nwoltman! Do you have some idea when can |
@skinny85 You could temporarily use my branch in your {
"dependencies": {
"handlebars": "nwoltman/handlebars.js#patch-1"
}
} |
Like I said, we're a transitive client of yours, so that's not really an option :( |
With Yarn you can use dependency resolutions. Unfortunately, npm doesn't have this functionality. |
Yep, we currently use NPM, although we plan to move to Yarn soon. |
sorry about that. I wanted to add additional linting because just before my release, the saucelabs-tests failed again with internet-explorer. I am currently doing most of this stuff on my own and there is no review process for changes that I make myself. Any idea how to check on such mistakes easily in the CI? Want to volunteer as a reviewer in the future? |
I have commit the fix and I'm now waiting for the Travis-CI build to finish. Then I'll release 4.5.1 |
Thanks @nknapp ! |
I can tell you what we do in our project. We have a test that first does an
Sure :). You've been super helpful with this issue, so I'm more than happy to return the favor. Feel free to tag me on any PRs you want feedback on. |
Thanks. Well, it is no failing peer dependency in the |
Should be fixed in 4.5.1 |
What I meant is you try it on a new |
And thanks again for the super quick fix! |
Hey all,
I'm from the AWS CDK project. We are a transitive client of Handlebars through Jest. After the 4.5.0 release, our canaries started failing. It's because we check whether our dependency closure does not contain unmet peer dependencies with
npm ls
. After Handlebars4.5.0
was released, this is what we see:I believe the issue is this commit added a dependency on
eslint-plugin-compat
, which only has a devDependency oneslint
(but a peer dependency on it!).Would it be possible to release
4.5.1
that adds the dependency on"eslint": "^3.3.0"
?Thanks,
Adam
The text was updated successfully, but these errors were encountered: