Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use toHTML vs. instanceof checks for SafeString #890

Merged
merged 1 commit into from
Nov 8, 2014
Merged

Conversation

kpdecker
Copy link
Collaborator

Allows for us to play nicely in environments such as Node that could have
multiple versions of the library loaded. Also allows for implementors to
provide their own behavior, provided they know what they are doing.

Fixes #886

@mmun
Copy link
Contributor

mmun commented Oct 26, 2014

👍 This is useful for HTMLBars as well.

@dominicbarnes
Copy link

👍 +1

@kpdecker kpdecker added this to the 3.0 milestone Nov 8, 2014
Allows for us to play nicely in environments such as Node that could have multiple versions of the library loaded. Also allows for implementors to provide their own behavior, provided they know what they are doing.

Fixes #886
kpdecker added a commit that referenced this pull request Nov 8, 2014
Use toHTML vs. instanceof checks for SafeString
@kpdecker kpdecker merged commit e779ecf into master Nov 8, 2014
@kpdecker kpdecker deleted the to-html-safe branch November 8, 2014 23:47
@dominicbarnes
Copy link

Is there any chance of this particular change being released sooner that 3.0? Perhaps as 2.1 or something? (unless 3.0 is really soon?)

This would be super-helpful to me right away, I'm not sure if I'm the only one though.

@kpdecker
Copy link
Collaborator Author

My goal is for 3.0 to be soon. I had trouble justifying if this was a
breaking change to myself or not. In the end it felt better to err on the
side of calling it breaking since toHTML could easily be a common name
and I didn't want to introduce surprises in areas that could have security
implications.

On Tue, Nov 11, 2014 at 1:49 PM, Dominic Barnes notifications@github.com
wrote:

Is there any chance of this particular change being released sooner that
3.0? Perhaps as 2.1 or something? (unless 3.0 is really soon?)

This would be super-helpful to me right away, I'm not sure if I'm the
only one though.


Reply to this email directly or view it on GitHub
#890 (comment).

@dominicbarnes
Copy link

Sounds good, I'll be watching and waiting for 3.0 then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SafeString to context (or use duck-typing)
3 participants