Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make the command server shortcut configurable #7

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

fidgetingbits
Copy link
Contributor

No description provided.

@saidelike
Copy link
Contributor

Sounds good. We also need to discuss what default shortcut we want for people to use on the different platform, see #20

then I guess we need to set the setting for the different platforms by default in neovim-talon?

@fidgetingbits
Copy link
Contributor Author

Me changing this is pending on if ctrl-` works on Windows, in which case we can have a single default, otherwise I will set the default based on the platform. See saidelike/cursorless#2

@saidelike
Copy link
Contributor

saidelike commented Jun 12, 2024

Me changing this is pending on if ctrl-` works on Windows, in which case we can have a single default, otherwise I will set the default based on the platform. See saidelike/cursorless#2

I would be tempted to keep different default shortcuts for different platform as ctrl-shift-f12 is better for Windows so each platform has its own prefered one

@saidelike
Copy link
Contributor

saidelike commented Jun 12, 2024

I would set the default setting in neovim-talon based on platform

@fidgetingbits
Copy link
Contributor Author

Fixed now. I mix linux and mac shortcut for now, as I did that in cursorless.nvim as well. Can change it if/when it becomes an issue to actually separate, but I think it should be ok for now.

I would set the default setting in neovim-talon based on platform

@saidelike saidelike merged commit 607ff11 into main Jun 13, 2024
@saidelike saidelike deleted the shortcut-setting branch June 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants