Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guides: remove sample hsd.conf from configuration guide #78

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Conversation

pinheadmz
Copy link
Member

Closes #72

the sample hsd.conf was removed in handshake-org/hsd@299aa7b

@pinheadmz pinheadmz requested review from boymanjor and tynes May 27, 2020 15:32
@kilpatty
Copy link

Thoughts on replacing this link w/ an example to an actual sample hsd.conf? I'm happy to write one up as I actually use it pretty extensively.

@pinheadmz
Copy link
Member Author

pinheadmz commented May 27, 2020

@kilpatty it was removed from hsd because the sample was so outdated and unmaintained, also had mostly default values and users were just copy+pasting it and not understanding what they were doing.

Maybe at the bottom of this guide we can add a short sample with a few default settings, so if users actually paste it, they won't affect anything, but they'll understand the syntax?

Example: 9c2cd70

@tynes
Copy link
Collaborator

tynes commented Jun 2, 2020

Thoughts on replacing this link w/ an example to an actual sample hsd.conf? I'm happy to write one up as I actually use it pretty extensively.

Is this something you still plan on doing @kilpatty?

@pinheadmz
Copy link
Member Author

@tynes I added a sample to this PR in the last commit: 9c2cd70

sorry i had the wrong link in my last comment

src/guides/config.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of additional sentences that describe the syntax of the config file + config parsing from multiple locations.

@pinheadmz
Copy link
Member Author

@tynes thanks dude, integrated your feedback at 000ef20

@tynes
Copy link
Collaborator

tynes commented Jun 3, 2020

Looks good to me, ready to merge.

ACK 000ef20

@pinheadmz pinheadmz merged commit 64c8aad into master Jun 3, 2020
pinheadmz added a commit that referenced this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hsd sample.conf url broken
3 participants