-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guides: remove sample hsd.conf from configuration guide #78
Conversation
Thoughts on replacing this link w/ an example to an actual sample hsd.conf? I'm happy to write one up as I actually use it pretty extensively. |
@kilpatty it was removed from hsd because the sample was so outdated and unmaintained, also had mostly default values and users were just copy+pasting it and not understanding what they were doing. Maybe at the bottom of this guide we can add a short sample with a few default settings, so if users actually paste it, they won't affect anything, but they'll understand the syntax? Example: 9c2cd70 |
Is this something you still plan on doing @kilpatty? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of additional sentences that describe the syntax of the config file + config parsing from multiple locations.
Looks good to me, ready to merge. ACK 000ef20 |
Closes #72
the sample hsd.conf was removed in handshake-org/hsd@299aa7b