Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of activesupport by bumping middleman version #79

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

pinheadmz
Copy link
Member

@pinheadmz pinheadmz commented Jun 2, 2020

This security alert went out on github and alerted us because of a dependency: GHSA-2p68-f74v-9wc6

Middleman was also updated about the dependency and released a new version very quickly: middleman/middleman#2326

I hit some obstacles running the build with the new middleman since they upgraded from https://github.com/sass/ruby-sass to https://github.com/sass/sassc-ruby

It took me a while to finally figure out how to upgrade middleman and still render the css correctly: slatedocs/slate#1197 (comment)

... which is why there is a second commit to downgrade sprockets.

I'd appreciate if reviewers could test this PR on their own machines and make sure that bin/build (from directory root) builds everything correctly especially the api docs and make sure everything looks right, including icons and fonts.

If it works out for reviewers then we can merge this and build again.

@tynes
Copy link
Collaborator

tynes commented Jun 3, 2020

Got an error message the first time that I tried building, but it informed me that I needed to install a different version of bundler. Once I did that, then bin/build worked fine.

Navigating through the docs site, I didn't notice differences in icons or fonts.

ACK 9f23130

@pinheadmz
Copy link
Member Author

@tynes your ACK is for 9f23130 but there's one other commit on this branch, e019cc5

@tynes
Copy link
Collaborator

tynes commented Jun 3, 2020

Ready to merge

ACK e019cc5

@pinheadmz
Copy link
Member Author

Thanks! 🥳

@pinheadmz pinheadmz merged commit 5869c41 into handshake-org:master Jun 3, 2020
pinheadmz added a commit that referenced this pull request Jun 3, 2020
pinheadmz added a commit that referenced this pull request Jun 4, 2020
This reverts commit 5869c41, reversing
changes made to affc314.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants