Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: opcodes that introspect tx outputs #226

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

pinheadmz
Copy link
Member

Increase test coverage of Script module with the new handshake opcodes OP_CHECKOUTPUT and OP_TYPE.

These unit tests could be the basis for an integration test or separate application that uses hot/cold keys to build the update/transfer name-ownership script described in the whitepaper.

@codecov-io
Copy link

codecov-io commented Jul 17, 2019

Codecov Report

Merging #226 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage   52.99%   53.03%   +0.04%     
==========================================
  Files         129      129              
  Lines       35773    35773              
  Branches     6032     6032              
==========================================
+ Hits        18957    18973      +16     
+ Misses      16816    16800      -16
Impacted Files Coverage Δ
lib/script/script.js 58% <0%> (+0.07%) ⬆️
lib/primitives/covenant.js 70.18% <0%> (+0.45%) ⬆️
lib/primitives/coin.js 78.19% <0%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1ef7a...4275950. Read the comment docs.

@pinheadmz
Copy link
Member Author

Updated to include OP_TYPE only, assuming #230 will be merged and remove OP_CHECKOUTPUT from the protocol

Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4275950

This looks good to me. I cloned and increased the size of the iteration loop to outside of the set of defined covenants and it still worked.

@pinheadmz
Copy link
Member Author

pinheadmz commented Aug 11, 2020

rebase to c5daaaa:
rebase on master, diff is null

$ git range-diff  4275950~..4275950  c5daaaa~..c5daaaa
1:  42759501 = 1:  c5daaaad test: OP_TYPE

@pinheadmz pinheadmz merged commit d1b42a6 into handshake-org:master Aug 11, 2020
@coveralls
Copy link

coveralls commented Aug 11, 2020

Pull Request Test Coverage Report for Build 204169981

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 58.997%

Files with Coverage Reduction New Missed Lines %
lib/protocol/consensus.js 1 82.79%
Totals Coverage Status
Change from base Build 204069182: 0.01%
Covered Lines: 19287
Relevant Lines: 30406

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants